[php8-compat] Partial Fix of hook tests for php8 #20545
Conversation
|
(Standard links)
|
seamuslee001
force-pushed
the
hook_test_fix_part1
branch
from
afd93a0 to
6514beb
Compare
|
Jenkins re test this please |
| @@ -26,8 +26,10 @@ | |||
| <td class="label">{$form.description.label} | |||
| {if $action == 2}{include file='CRM/Core/I18n/Dialog.tpl' table='civicrm_option_group' field='description' id=$id}{/if}</td><td>{$form.description.html}</td> | |||
| </tr> | |||
| {if !empty($form.name)} | |||
| <td class="label">{$form.name.label}</td> | |||
| <td>{$form.name.html}</td></tr> | |||
There was a problem hiding this comment.
There's a closing </tr> tag in this if block that doesn't match anything else inside the block.
There was a problem hiding this comment.
Thanks @colemanw have fixed that up now hopefully
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks @demeritcowboy fixed it properly now I would say
There was a problem hiding this comment.
Yes looks good. I can't see where this field comes up though - I think name is not exposed anymore.
seamuslee001
force-pushed
the
hook_test_fix_part1
branch
from
6514beb to
ee65c22
Compare
seamuslee001
force-pushed
the
hook_test_fix_part1
branch
from
ee65c22 to
b0e06ce
Compare
| @@ -38,22 +38,22 @@ | |||
| <span class="description">{ts}A "string value" or regular expression to be redacted (replaced).{/ts}</span> | |||
| </td> | |||
| </tr> | |||
| {else} | |||
| {elseif !empty($form.label)} | |||
There was a problem hiding this comment.
This would also hide financial_account_id when it didn't before, since despite the indenting fin id is within this block. But I'm not sure what screen that comes up on. Clicking around the related screens looks ok.
|
Clicked around and didn't see any obvious issues. Removing possibly never-used stuff would be out of scope. |
|
thanks @demeritcowboy |
Overview
This partially fixes some test failures on testing hooks
Before
Test fails
After
Test fails but not for these reasons
ping @eileenmcnaughton @totten @colemanw @demeritcowboy