[php8-compact] Fix Report tests failing on php8 #20549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
It took me a few reads before I managed to get to the end without glazing over but I feel pretty sure I read this all carefully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the following test failures on php8
-CRM_Report_Utils_ReportTest::testOutputPrint
Undefined array key "groups"
/home/jenkins/bknix-edge/build/build-0/web/sites/default/files/civicrm/templates_c/en_US/%%1B/1BD/1BD7DE8F%%Statistics.tpl.php:14
-CRM_Report_Utils_ReportTest::testOutputPdf
Undefined array key "groups"
/home/jenkins/bknix-edge/build/build-0/web/sites/default/files/civicrm/templates_c/en_US/%%1B/1BD/1BD7DE8F%%Statistics.tpl.php:14
Before
Those report tests fail on php8
After
Those report tests pass on php8
ping @eileenmcnaughton @demeritcowboy @totten @colemanw