Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compact] Fix Session Test errors in php8 #20593

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes the following test errors on php8

  • CRM_Core_SessionTest::testSetStatusWithTitleOnly
    Undefined array key "infoMessage"
  • CRM_Core_SessionTest::testSetStatusWithBoth
    Undefined array key "infoType"
  • CRM_Core_SessionTest::testSetStatusWithTextOnly
    Undefined array key "infoType"

Before

CRM_Core_SessionTest fails on php8

After

CRM_Core_SessionTest passes on php8

ping @eileenmcnaughton @totten @colemanw @demeritcowboy

@civibot
Copy link

civibot bot commented Jun 14, 2021

(Standard links)

@civibot civibot bot added the master label Jun 14, 2021
@eileenmcnaughton eileenmcnaughton merged commit 219803e into civicrm:master Jun 14, 2021
@eileenmcnaughton eileenmcnaughton deleted the session_test_fix branch June 14, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants