dev/report#68 Fix smart group crash when ordering by aggregated column #20610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@colemanw this should be against the rc shouldn't it? Sounds like a regression or possibly an 'arguably regression' |
Fixes dev/report#68
|
Ok I've rebased for the RC. Marking MOP based on review in gitlab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes https://lab.civicrm.org/dev/report/-/issues/68
Before
SearchKit can crash smart groups when ordering by an aggregated column.
After
Fixed.
Technical Details
The smart group query removes everything from the SELECT clause, removing calculated fields which may be used by ORDER BY clause.