Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#2656 Fix getReferencesToContactTable to ignore non-id references #20639

Merged
merged 1 commit into from
Jun 18, 2021
Merged

dev/core#2656 Fix getReferencesToContactTable to ignore non-id references #20639

merged 1 commit into from
Jun 18, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jun 17, 2021 •
edited
Loading

Overview

Ensures the deduper doesn't crash due to nonstandard foreign key references.

https://lab.civicrm.org/dev/core/-/issues/2656

@civibot
Copy link

civibot bot commented Jun 17, 2021

(Standard links)

@civibot civibot bot added the master label Jun 17, 2021
@eileenmcnaughton
Copy link
Contributor

test fail looks unrelated

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

Seems like a sensible approach - I can merge the test once this is merged

@eileenmcnaughton eileenmcnaughton changed the title Fix getReferencesToContactTable to ignore non-id references dev/core#2656 Fix getReferencesToContactTable to ignore non-id references Jun 18, 2021
@eileenmcnaughton eileenmcnaughton merged commit bc5dc12 into civicrm:master Jun 18, 2021
@eileenmcnaughton eileenmcnaughton deleted the getReferencesToContactTable branch June 18, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @eileenmcnaughton