[NFC] [Test] Cleanup on membership type test #20649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -1915,9 +1916,10 @@ public function quickCleanUpFinancialEntities() { | |||
| 'civicrm_price_field', | |||
| ]; | |||
| $this->quickCleanup($tablesToTruncate); | |||
| $this->disableTaxAndInvoicing(); | |||
There was a problem hiding this comment.
Actually this line was removed for no reason in the end - doesn't it look prettier here though?
eileenmcnaughton
force-pushed
the
mem_clean
branch
from
e88684a to
d274f51
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
mem_clean
branch
2 times, most recently
from
22e2a2a to
d0b895d
Compare
eileenmcnaughton
force-pushed
the
mem_clean
branch
from
d0b895d to
74f4a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[NFC] [Test] Cleanup on membership type test
Rely on tearDown to delete created memberships