Remove deprecated use of format money

[eileenmcnaughton]

Overview

Deprecation errors are being logged due to passing the html for min_amount to the money::format funciton. This is a read only field

Removing that call results in a slight loss of formatting but it's broken before AND after on sites with non-US decimarl separators and the field feels obscure enough and is not an input field so my money (guffaw) says no-one will miss the currency symbol.

It's a bit of work to fix it so it DOES format correctly as js is involved & it has never been reported

Before

A deprecation notice is logged due to passing html to Money;;format()

The site default currency is shown but the thousand separators are incorrect.

After

The currency symbol has been sacrificed to get rid of the deprecation notice - the thousand separators are still incorrect

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[demeritcowboy]

Agree it's broken before anyway. And there's some precedent for removing these crmMoney html calls at the expense (guffaw 2) of a missing currency symbol pending a better fix.