dev/core#2663 - Setup - Consistently handle special characters per URL conventions #20713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Note: There was a small UI quirk in how the initial commit displayed the |
totten
commented
Jun 25, 2021
…L conventions Overview -------- This addresses a problem with the setup UI when installing CiviCRM with certain database credentials. Specifically, it handles special characters more correctly. https://lab.civicrm.org/dev/core/-/issues/2663 Before ------ If the database password requires any special characters (e.g. "#" or "&"), then they cannot correctly entered. There are two ways you might try to enter a password (e.g. plain `mysql://myuser:top#secret...`or URL-encoded `mysql://myuser:top%23secret...`). Neither of these work. (The plain notation might pass the validator, but it won't be written correctly to disk. The URL-encoded notation won't pass the validator.) After ----- You may use special characters, as long as the URL is properly encoded, e.g. `mysql://myuser:top%23secret...`
|
Thanks @totten I did
I think the messaging is fine. This looks good to merge. |
|
merging as per review by @kcristiano |
|
Thanks @kcristiano @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This addresses a problem with the setup UI when installing CiviCRM with certain database credentials. Specifically, it handles special characters more correctly.
https://lab.civicrm.org/dev/core/-/issues/2663
Before
If the database password requires any special characters (e.g. "#" or "&"), then it is impossible to enter them correctly.
There are two ways you might try to enter a password like
top#secret(e.g. plainmysql://myuser:top#secret...or URL-encodedmysql://myuser:top%23secret...). Neither of these work. (e.g. The URL-encoded notation won't pass the validator. The plain notation might pass the validator, but it won't be written correctly to disk.)After
You may use special characters, as long as the URL is properly encoded, e.g.
mysql://myuser:top%23secret...Additionally, there is some help text pointing this out. (Highlighted in screenshot.)