dev/core#2659 Move group cleanup to latest release #20756
Conversation
|
(Standard links)
|
|
A few versions back I went to a lot of trouble to fix api calls so they wouldn't fatal on not-yet-added fields during upgrade mode. Any idea why that didn't help this situation? |
|
@colemanw I didn't test - I figured this was a quick & easy way to address this. I'ts obviously a bit obscure from the report so I didn't want to put much time into it |
| $this->addTask('Update smart groups where jcalendar fields have been converted to datepicker', 'updateSmartGroups', [ | ||
| 'datepickerConversion' => [ | ||
| 'birth_date', | ||
| 'deceased_date', | ||
| 'case_start_date', | ||
| 'case_end_date', | ||
| 'mailing_job_start_date', | ||
| 'relationship_start_date', | ||
| 'relationship_end_date', | ||
| 'event', | ||
| 'relation_active_period_date', | ||
| 'created_date', | ||
| 'modified_date', | ||
| ], | ||
| ]); |
There was a problem hiding this comment.
This task is missing from the new upgrade?
There was a problem hiding this comment.
Yeah - not sure why I thought that didn't relate - added now
eileenmcnaughton
force-pushed
the
539
branch
2 times, most recently
from
a461f4d to
a4856ea
Compare
|
test this please |
|
Still confused: Nobody has reproduced the problem with or without smart groups, and it's unlikely to be investigated further or have this patch tested on the original site, which may even be a different issue (we don't have confirmation of which field or even table "No such field" is referring to on that site). |
|
@demeritcowboy yeah - it feels like this would fix it - but as you say we haven't reproduced |
|
And Jenkins is making you work for it... |
|
@demeritcowboy yeah! - not the quick fix I'd hoped |
|
Failure is an intermittent fail which is fixed in 5.40 but this is against 5.39. But still not sure whether this is needed/desired. |
|
Oh well if it's intermittent let's get the green tick so we can decide without a red cross in our face |
|
test this please |
|
Spot-checked several of the conversion functions - agree that they appear idempotent. (TLDR: Once you rename a smart-group criterion away from an old name... it no longer matches the old name... so it shouldn't match again...) There are some intervening changes in the |
Overview
dev/core#2659 Move group cleanup to latest release
Before
A site upgrading from pre 5.20 would hit errors trying to process smart group updates due to fields being in the DAO but not yet the table.
After
The updates have been moved to 5.39 - after the fields are added
Technical Details
These updates will have no impact on sites that have already run them
Comments
@demeritcowboy