dev/core#27 Move check for phone function to a check

[eileenmcnaughton]

Overview

dev/core#27 Move check for phone function to a check
https://lab.civicrm.org/dev/core/-/issues/27

Before

The check is run when crudding phone numbers

After

The check is part of system status checks

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

This is going to be a little less fool-proof than the original version which would guarantee the sql function exists before writing a phone record (also at the expense of an extra query before writing phone records).

But checks are a much more standard approach, than the ad-hoc thing.

[demeritcowboy]

All the PR test sites are showing this warning. Not sure yet if it's something to do with the way those sites are created since don't see it on e.g dmaster.demo.