-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test set up to user Order api #20780
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Standard links)
|
eileenmcnaughton
force-pushed
the
pay_order
branch
from
July 6, 2021 08:24
d26f80c
to
1e232ad
Compare
test this please |
eileenmcnaughton
force-pushed
the
pay_order
branch
from
July 6, 2021 18:36
1e232ad
to
677df21
Compare
This now includes #20779 as that has a fix for the situation where memberships have more than one member organization |
test this please |
eileenmcnaughton
force-pushed
the
pay_order
branch
from
July 6, 2021 23:34
677df21
to
07103d0
Compare
@colemanw also this - one line of change + test clean up. The change is so that the order recurring contribution id reaches the membership |
@eileenmcnaughton can you rebase this please? |
Note this includes the order api ensuring that the contribution_recur_id is passed through to any created memberships
eileenmcnaughton
force-pushed
the
pay_order
branch
from
July 7, 2021 20:43
07103d0
to
f34913f
Compare
unrelated fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this includes the order api ensuring that the contribution_recur_id is passed through to
any created memberships
Overview
Fix test set up to user Order api
Before
Test uses mishmash set up
After
Test uses api
Technical Details
Comments