Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test set up to user Order api #20780

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 6, 2021

Note this includes the order api ensuring that the contribution_recur_id is passed through to
any created memberships

Overview

Fix test set up to user Order api

Before

Test uses mishmash set up

After

Test uses api

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jul 6, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

This now includes #20779 as that has a fix for the situation where memberships have more than one member organization

@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

@colemanw also this - one line of change + test clean up. The change is so that the order recurring contribution id reaches the membership

@colemanw
Copy link
Member

colemanw commented Jul 7, 2021

@eileenmcnaughton can you rebase this please?

Note this includes the order api ensuring that the contribution_recur_id is passed through to
any created memberships
@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 81a5360 into civicrm:master Jul 7, 2021
@eileenmcnaughton eileenmcnaughton deleted the pay_order branch July 7, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants