Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#2680 Remove rows in the civicrm_contribution_product table t… #20814

Merged
merged 1 commit into from
Jul 8, 2021
Merged

dev/core#2680 Remove rows in the civicrm_contribution_product table t… #20814

merged 1 commit into from
Jul 8, 2021

Conversation

seamuslee001
Copy link
Contributor

…hat have bad product_ids in them

Overview

This aims to fix this lab issue

Before

Possible DB error in upgrade

After

No DB error

ping @eileenmcnaughton @monishdeb @kcristiano

@civibot
Copy link

civibot bot commented Jul 8, 2021

(Standard links)

@civibot civibot bot added the master label Jul 8, 2021
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 good to merge - but haven't we branched the rc?

@seamuslee001 seamuslee001 changed the base branch from master to 5.40 July 8, 2021 21:50
@civibot civibot bot added 5.40 and removed master labels Jul 8, 2021
@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton good point changed base now

@eileenmcnaughton
Copy link
Contributor

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 3efec37 into civicrm:5.40 Jul 8, 2021
@eileenmcnaughton eileenmcnaughton deleted the dev_core_2680 branch July 8, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.40 merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton