Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix permission to access task list #21045

Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Aug 6, 2021

Overview

Fixes a regression preventing access to the tasks menu in search displays for non-admin users.

Before

For non-admin users, the task menu just spins:

image

After

Task menu shows for all users with "access CiviCRM"

Technical Details

This regressed in 06ea32c, as a new api action was added but permissions were not declared.

This regressed in 06ea32c, as a new api action was added but permissions were not declared.
@civibot
Copy link

civibot bot commented Aug 6, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

@colemanw should this be against the rc?

@colemanw colemanw changed the base branch from master to 5.40 August 6, 2021 22:32
@civibot civibot bot added 5.40 and removed master labels Aug 6, 2021
@colemanw
Copy link
Member Author

colemanw commented Aug 6, 2021

Good catch @eileenmcnaughton - I actually based it on that branch but forgot to specify 5.40 when I opened the PR.

@eileenmcnaughton
Copy link
Contributor

@colemanw - oh - has the rc been cut? 5.40 is the stable release now isn't it?

@colemanw
Copy link
Member Author

colemanw commented Aug 6, 2021

Yea branch 5.41 doesn't exist yet, so I guess we have to merge it to master regardless of if this is deemed important enough to go into 5.40.

@eileenmcnaughton
Copy link
Contributor

Ok - I replicated this & it worked - none of the 3 actions worked for me :-( - ie they displayed but my user got a permission error on selecting - But I suspect that is not a regression

image

@eileenmcnaughton
Copy link
Contributor

@colemanw I gave it MOP - but I guess you have to flip it back to master

@colemanw colemanw changed the base branch from 5.40 to master August 6, 2021 23:19
@civibot civibot bot added master and removed 5.40 labels Aug 6, 2021
@eileenmcnaughton eileenmcnaughton merged commit b2665ac into civicrm:master Aug 6, 2021
@eileenmcnaughton eileenmcnaughton deleted the fixSearchKitTaskPermissions branch August 6, 2021 23:31
@eileenmcnaughton
Copy link
Contributor

@colemanw wanna do a backport against 5.40 now?

@colemanw colemanw restored the fixSearchKitTaskPermissions branch August 7, 2021 00:05
@totten totten deleted the fixSearchKitTaskPermissions branch August 7, 2021 01:59
@wyde22
Copy link
Contributor

wyde22 commented Aug 12, 2021

Hi @colemanw i'm testing and it works. thanks so lot ;)

@eileenmcnaughton
Copy link
Contributor

@wyde22 I've lost track of this one - I'm thinking it is in the rc but NOT in 5.40.x & we should consider backporting?

@colemanw
Copy link
Member Author

@eileenmcnaughton it was backported to 5.40

@eileenmcnaughton
Copy link
Contributor

thanks @colemanw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants