CRM-19674 Add ability to see at a glance if a contribution is part of… #9421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seamuslee001
force-pushed
the
recur_icon
branch
from
6b2d5d6 to
c6ba3ef
Compare
|
tested, working fine |
|
@pradpnayak the customer has come back requesting the text (recurring payment) is cut down to just (R) - this is at @petednz suggestion I think - on the basis that it's less intrusive to eyeballing the numbers - what do you think? I'd need to make an edit to do that |
eileenmcnaughton
force-pushed
the
recur_icon
branch
from
c6ba3ef to
d911178
Compare
… a recurring series Note this is a subset of civicrm@c6ba3ef It re-instates the display of the word recurring, but leaves out the extra column for recurring & sortability based on that. This is mostly because I wanted to get the PR resolved & merged & hence left out the stuff that did not seem like I had a consensus on. However, I do think the loss of sortability on recurring is a shame & hence kept a link to the commit if anyone wants to revisit
eileenmcnaughton
force-pushed
the
recur_icon
branch
from
d911178 to
2e80df5
Compare
|
This got bogged down in discussion about the best approach & possible issues. I have reduced back to the minimum that was generally agreed to get it resolved & merged & closed. I will merge this on pass as this part was QA'd Per my commit Note this is a subset of c6ba3ef |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-19674 Add ability to see at a glance if a contribution is part of…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a recurring series