CRM-20219 Update activity fields in profiles to use date picker #9935
Conversation
eileenmcnaughton
commented
Mar 5, 2017
•
eileenmcnaughton
commented
- CRM-20219: Switch activity date time to use datepicker in profiles
eileenmcnaughton
force-pushed
the
activity_cust_date
branch
from
20b1941 to
2a66c16
Compare
| @@ -95,7 +95,7 @@ public function buildQuickForm() { | |||
| $ufGroupId = $this->get('ufGroupId'); | |||
|
|
|||
| if (!$ufGroupId) { | |||
| CRM_Core_Error::fatal('ufGroupId is missing'); | |||
| throw new CRM_Core_Exception('The profile id is missing'); | |||
There was a problem hiding this comment.
Just a general improvement, unrelated
| @@ -108,7 +108,7 @@ public function buildQuickForm() { | |||
| $suppressFields = FALSE; | |||
| $removehtmlTypes = array('File', 'Autocomplete-Select'); | |||
| foreach ($this->_fields as $name => $field) { | |||
| if ($cfID = CRM_Core_BAO_CustomField::getKeyID($name) && | |||
There was a problem hiding this comment.
unused var, tidy up
| $dao->fetch(); | ||
|
|
||
| // Get Activity Type ID | ||
| $value['activity_type_id'] = $dao->activity_type_id; |
There was a problem hiding this comment.
all this just to backfill those fields if not in the form. Not required if we use the api
| @@ -228,10 +231,6 @@ public function postProcess() { | |||
| $value['details'] = $value['activity_details']; | |||
| } | |||
|
|
|||
| if (!empty($value['activity_duration'])) { | |||
There was a problem hiding this comment.
tested & once using the api this doesn't add anything
|
@seamuslee001 I tried to figure out how to test this. In 4.6 there is a functionality to update an activity & contact at the same time, e.g at a url like civicrm/profile/edit?result=1&id={$contactID}&aid={$activityID}&gid={$profileID} I am pretty sure that functionality is broken in 4.7, prior to this. The other place I could expose this field was batch update from an activity search. I found some breakages pre-existing here (activity type is rendered as an integer), but I was able to demonstrate the activity date field updated ok |
|
@eileenmcnaughton i tested the batch update and couldn't see any issue here so i think we can merge this |
CRM-20219 Update activity fields in profiles to use date picker
