CRM-20062 update Kenyan provinces #9937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JKingsnorth any chance you could review this revised version? The code is very prone to going stale |
JKingsnorth
approved these changes
Mar 8, 2017
There was a problem hiding this comment.
+1 for the new generic function =]
I tested:
- Create a contact that uses a deprecated province
- Run the upgrade
- The contact still has the province 'former - ' and the other old provinces are removed. The new provinces have been added.
This seems like a good solution to me.
|
Thanks @JKingsnorth |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-20062 update Kenyan provinces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative PR taking feedback into account