-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drupal Views CiviCRM: Allow Participant record to be used from Event. #539
Drupal Views CiviCRM: Allow Participant record to be used from Event. #539
Conversation
(Standard links)
|
9f494ce
to
d2fee9b
Compare
@colemanw @eileenmcnaughton @seamuslee001 @jackrabbithanna < this is the new PR :) it has the changes suggested. Please note that the civicrm_api check is still needed for the API call. If someone else could please test this, and let Coleman know if you're happy for it to be merged, that would be amazeballs, and I'd happily return favour in future. |
<?php | ||
|
||
/** | ||
* This relationship handler is used when joining the civicrm_relationship table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohnFF are you able to update this code comment
'base' => 'civicrm_participant', | ||
'base field' => 'event_id', | ||
'handler' => 'civicrm_handler_relationship_participant', | ||
'label' => t('CiviCRM Participant (starting from Event)'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this string (note that it appears twice, if we decide to change it).
What about "CiviCRM Event Participant"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @colemanw - this string appears twice in the same way that it does for CiviCRM Relationship. I also looked to "starting from Contact A" as guidance, although here I see it's probably not necessary. I've adjusted the PR accordingly.
ee643db
to
6969736
Compare
6969736
to
7fcce8b
Compare
You can check out the end results here: http://civicrm-drupal-john886170.codeanyapp.com (site may time out, I'm unsure atm). |
No description provided.