Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal Views CiviCRM: Allow Participant record to be used from Event. #539

Conversation

JohnFF
Copy link
Contributor

@JohnFF JohnFF commented Aug 5, 2018

No description provided.

@civibot
Copy link

civibot bot commented Aug 5, 2018

(Standard links)

@JohnFF JohnFF force-pushed the feature/view_event_participant_relationship branch from 9f494ce to d2fee9b Compare August 5, 2018 15:01
@JohnFF
Copy link
Contributor Author

JohnFF commented Aug 5, 2018

@colemanw @eileenmcnaughton @seamuslee001 @jackrabbithanna < this is the new PR :) it has the changes suggested.

Please note that the civicrm_api check is still needed for the API call.

If someone else could please test this, and let Coleman know if you're happy for it to be merged, that would be amazeballs, and I'd happily return favour in future.

<?php

/**
* This relationship handler is used when joining the civicrm_relationship table
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnFF are you able to update this code comment

'base' => 'civicrm_participant',
'base field' => 'event_id',
'handler' => 'civicrm_handler_relationship_participant',
'label' => t('CiviCRM Participant (starting from Event)'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this string (note that it appears twice, if we decide to change it).
What about "CiviCRM Event Participant"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @colemanw - this string appears twice in the same way that it does for CiviCRM Relationship. I also looked to "starting from Contact A" as guidance, although here I see it's probably not necessary. I've adjusted the PR accordingly.

@JohnFF JohnFF force-pushed the feature/view_event_participant_relationship branch 3 times, most recently from ee643db to 6969736 Compare August 12, 2018 14:10
@JohnFF JohnFF force-pushed the feature/view_event_participant_relationship branch from 6969736 to 7fcce8b Compare August 12, 2018 14:21
@JohnFF
Copy link
Contributor Author

JohnFF commented Aug 12, 2018

image
image

@JohnFF
Copy link
Contributor Author

JohnFF commented Aug 12, 2018

You can check out the end results here: http://civicrm-drupal-john886170.codeanyapp.com (site may time out, I'm unsure atm).

@colemanw
Copy link
Member

@colemanw colemanw merged commit 80d0f5d into civicrm:7.x-master Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants