[REF] Follow up fix to fixing note entity tables in views

[seamuslee001]

ping @colemanw @totten @eileenmcnaughton

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I think both the before and after versions are incorrect because they access lower-level data instead of doing a pseudoconstant lookup and letting that layer worry about where the data is coming from. If it had been doing this from the beginning, we wouldn't need any change here:

Suggested change

	$noteEntityTables = civicrm_api3('OptionValue', 'get', ['option_group_id' => 'note_used_for'])['values'];
	foreach (array_values(CRM_Utils_Array::collect('value', $noteEntityTables)) as $entityTable) {
	$noteEntities = civicrm_api3('Note', 'getoptions', ['field' => "entity_table"])['values'];
	foreach (array_keys($noteEntities) as $entityTable) {

[seamuslee001]

good point @colemanw applied the patch here now