Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change connection and results charsets to utf8mb4 on MySQL 5.5.3+ #241

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

mfb
Copy link
Contributor

@mfb mfb commented Feb 18, 2019

CiviCRM isn't using utf8mb4 yet, but let's start the process of migrating to utf8mb4... We can use utf8mb4 as the connection and results charset on MySQL 5.5.3+

@civibot
Copy link

civibot bot commented Feb 18, 2019

(Standard links)

@civibot civibot bot added the master label Feb 18, 2019
@colemanw
Copy link
Member

@mlutfy can you review?

@mfb
Copy link
Contributor Author

mfb commented Aug 5, 2019

@totten this PR is essentially the same as civicrm/civicrm-setup#16 so I think it could be a candidate for being merged (the version logic is in the query itself rather than in PHP code).

@totten
Copy link
Member

totten commented Aug 8, 2019

@mfb yup, agree that looks sensible.

@totten
Copy link
Member

totten commented Aug 8, 2019

jenkins, test this please

@totten
Copy link
Member

totten commented Aug 8, 2019

It's also good to get this in at the start of the dev-cycle, which would be now. :)

Adding merge-on-pass. Small proviso: after the test-suite passes, but before merging, just do a quick login on the autobuild test site.

@totten totten merged commit 04a4a3d into civicrm:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants