Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deadlock error handling #258

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 3, 2019

This simply captures the error when the deadlock is first hit & then if the deadlock threshold it hit, causing an abort, it re-throws the original error - so the backtrace is retained.

We have been running this in production for about 6 months and the errors have been more meaningful

(@seamuslee001 you might have an interest)

@civibot
Copy link

civibot bot commented Jul 3, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

Change looks fine to me and unit test have passed so merging

@seamuslee001 seamuslee001 merged commit d86bbc7 into civicrm:master Aug 8, 2019
@eileenmcnaughton eileenmcnaughton deleted the dead branch August 9, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants