INTL_IDNA_VARIANT_2003 deprecated in PHP_7.2 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Looks right to me |
|
test fails are unrleated, i'm going to merge this as it is consistant with the change that is going to happen anyway via https://wiki.php.net/rfc/deprecate-and-remove-intl_idna_variant_2003 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INTL_IDNA_VARIANT_2003 is deprecated in php 7.2 but the function idn_to_ascii still uses it as default.
It seems the only way to avoid the warning is calling the function using explicitly the parameter INTL_IDNA_VARIANT_UTS46.