Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 3.2 #27

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Allow 3.2 #27

merged 2 commits into from
Jan 12, 2023

Conversation

adamzapasnik
Copy link
Contributor

No description provided.

Copy link
Contributor

@jydli jydli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to this repo! Just a quick question and a comment on the versioning.

spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
spec.bindir = 'exe'
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']

spec.add_dependency 'bundler-audit', '~> 0.9.0'
spec.add_development_dependency 'pry', '~> 0.13.0'
spec.add_development_dependency 'pry', '~> 0.14.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we updating this dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I was being lazy, pry/pry#2261 14.0 introduced a fix to work with Ruby 3.2

@@ -5,6 +5,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Added
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to also cut a new release for this, 2.2.0. Can you update the changes here to add that new version and the date?

This should also be updated in version.rb:

VERSION = '2.1.0'.freeze

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I can do it tomorrow morning (or you can merge and push the version update yourself 🙈 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amended

Copy link
Contributor

@jydli jydli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Once this PR has been merged, I'll go ahead and cut a new release!

@xmunoz
Copy link
Contributor

xmunoz commented Jan 12, 2023

Who has the ability to merge this PR?

@jydli jydli merged commit 1d90292 into civisanalytics:main Jan 12, 2023
@jydli
Copy link
Contributor

jydli commented Jan 12, 2023

Who has the ability to merge this PR?

Sorry, just merged and cut a new release!

@xmunoz
Copy link
Contributor

xmunoz commented Jan 13, 2023

Sorry, just merged and cut a new release!

Not sure what your release process is, but the new release does not appear here: https://rubygems.org/gems/ruby_audit

@jydli
Copy link
Contributor

jydli commented Jan 17, 2023

Sorry, just merged and cut a new release!

Not sure what your release process is, but the new release does not appear here: https://rubygems.org/gems/ruby_audit

Thank you bringing this up - I am currently in the process of getting the new release pushed and will update this PR once it's been done.

@jydli
Copy link
Contributor

jydli commented Jan 17, 2023

Sorry, just merged and cut a new release!

Not sure what your release process is, but the new release does not appear here: https://rubygems.org/gems/ruby_audit

Thank you bringing this up - I am currently in the process of getting the new release pushed and will update this PR once it's been done.

The new version should now be available here: https://rubygems.org/gems/ruby_audit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants