Skip to content
This repository has been archived by the owner on Aug 29, 2020. It is now read-only.

No Temps on Dell XPS9650 #101

Closed
mietzen opened this issue Jan 28, 2019 · 4 comments
Closed

No Temps on Dell XPS9650 #101

mietzen opened this issue Jan 28, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@mietzen
Copy link

mietzen commented Jan 28, 2019 •
edited by cjbassi
Loading

Required information:

  • gotop version (gotop -v): 2.0.0
  • The output of uname -a: Linux 4.19.14-300.fc29.x86_64 Increase height of sparkline to match widget height #1 SMP Wed Jan 9 21:30:35 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
  • Terminal shell (e.g. zsh or bash): zsh
  • Terminal emulator (e.g. iTerm or gnome terminal): xfce4-terminal
  • Any relevenat hardware info: Dell XPS9650 Fedora 29
  • tmux version if using tmux: None

Also please copy or attach the following file if it exists and contains logs:

  • Linux: ~/.local/state/gotop/errors.log: Empty

The temp widget is empty, but hwmon sensor data is available:

cat /sys/class/hwmon/hwmon*/temp*_*
107000
25000
59000
50000
CPU
50000
Ambient
44000
Ambient
36000
Other
100000
0
56000
Package id 0
100000
100000
0
56000
Core 0
100000
100000
0
54000
Core 1
100000
100000
0
53000
Core 2
100000
100000
0
51000
Core 3
100000
cat: /sys/class/hwmon/hwmon4/temp1_input: Network is down
@cjbassi cjbassi added the bug Something isn't working label Jan 28, 2019
@cjbassi
Copy link
Owner

cjbassi commented Jan 28, 2019

Can you paste the output of ls -al /sys/class/hwmon/hwmon*/temp*_* too?

Btw you can use

```
output
```

to format a large selection of text.

@mietzen
Copy link
Author

mietzen commented Jan 28, 2019

ls -al /sys/class/hwmon/hwmon*/temp*_*

ls -al /sys/class/hwmon/hwmon*/temp*_*
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon0/temp1_crit
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon0/temp1_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon1/temp1_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon2/temp1_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon2/temp1_label
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon2/temp2_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon2/temp2_label
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon2/temp3_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon2/temp3_label
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon2/temp4_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon2/temp4_label
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp1_crit
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp1_crit_alarm
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp1_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp1_label
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp1_max
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp2_crit
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp2_crit_alarm
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp2_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp2_label
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp2_max
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp3_crit
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp3_crit_alarm
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp3_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp3_label
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp3_max
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp4_crit
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp4_crit_alarm
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp4_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp4_label
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp4_max
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp5_crit
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp5_crit_alarm
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp5_input
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp5_label
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon3/temp5_max
-r--r--r--. 1 root root 4096 28. Jan 11:17 /sys/class/hwmon/hwmon4/temp1_input

Btw you can use

output

to format a large selection of text.

Thanks!

@cjbassi cjbassi mentioned this issue Feb 2, 2019
Open
@cjbassi
Copy link
Owner

cjbassi commented Feb 2, 2019

Thanks for the info. So I'm not seeing anything strange. Can you run this and copy the output here:

package main

import (
    "fmt"

    "github.com/shirou/gopsutil/host"
)

func main() {
    temperatures, err := host.SensorsTemperatures()
    fmt.Println(temperatures)
    fmt.Println(err)
}

cjbassi added a commit that referenced this issue Feb 4, 2019
@cjbassi
Fix temperatures not showing (#101, #103)
de03971
@cjbassi
Copy link
Owner

cjbassi commented Feb 4, 2019

So this should be fixed now! Let me know if you get any more issues otherwise.

@cjbassi cjbassi closed this as completed Feb 4, 2019
cjbassi added a commit that referenced this issue Feb 4, 2019
@cjbassi
Fix temperatures not showing (#101, #103)
897b202 
Sometimes a temperature sensor file in `/sys/class/hwmon/hwmon*/temp*_*` fill return 'ENETDOWN: Network is down' when being read for some reason, which gopsutil propogates up to gotop. gopsutil still returns a slice of valid temperatures when it errors, so we can render those instead of ignoring the return value.
cjbassi added a commit that referenced this issue Feb 4, 2019
@cjbassi
Fix temperatures not showing (#101, #103)
dbf25cd 
Sometimes a temperature sensor file in `/sys/class/hwmon/hwmon*/temp*_*` will return 'ENETDOWN: Network is down' when being read for some reason, which gopsutil propogates up to gotop. gopsutil still returns a slice of valid temperatures when it errors, so we can render those instead of ignoring the return value.
cjbassi added a commit to cjbassi/gopsutil that referenced this issue Feb 5, 2019
@cjbassi
[host][linux] Modify SensorsTemperatures error handling
ebda4e7 
- SensorsTemperatures now returns a slice of errors
- Previously, the function would return as soon as an error occured, but now we can continue to process the rest of the sensors even if an error occurs with one. Sometimes one sensor interface will be misbehaving but the rest will provide valid data.
- cjbassi/gotop#101, cjbassi/gotop#103
@xxxserxxx xxxserxxx mentioned this issue Feb 15, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjbassi @mietzen