Skip to content
This repository has been archived by the owner on Aug 29, 2020. It is now read-only.

Implement snap packaging, snaps are universal linux packages (#119) #120

Closed

Conversation

brlin-tw
Copy link
Contributor

@brlin-tw brlin-tw commented Mar 3, 2019

This patch implements the necessary details to package gotop as a snap that can be run on a broad range of supporting GNU/Linux distributions[1].

[1] https://snapcraft.io/

Signed-off-by: 林博仁(Buo-ren Lin) [email protected]

@cjbassi
Copy link
Owner

cjbassi commented Mar 6, 2019

Thanks a lot for the work you've put into this! And I'm glad you were able to get all the widgets to work by using the various snap plugins. I saw from the video you linked previously that not all the widgets work out of the box.

I'm not too familiar with snap, so a couple questions: Should I create a snap account and publish the snap under my own gotop-foo package name? And do I need to publish a new snap on each release?

And I'm planning on contacting @dawndiy at some point, but I'd like to get this figured out first.

@brlin-tw brlin-tw force-pushed the patch/implement-snap-packaging branch from df25e52 to 6690895 Compare March 6, 2019 04:41
@brlin-tw
Copy link
Contributor Author

brlin-tw commented Mar 6, 2019

Should I create a snap account and publish the snap under my own gotop-foo package name?

A snap developer(or to be specific, a Ubuntu One) account is required to publish the snap in the Snap Store. Whether using which package name is another issue.

do I need to publish a new snap on each release?

If you set-up the snapcraft build service it will build and publish a snap on every code push to the repository, you can promote the snap of the stable release to the stable release channel via the releases page:

demo snap promote opt

Check out Channels - Documentation for snaps: Universal Linux packages for more info regarding the snap release channels.

@brlin-tw brlin-tw changed the title Implement snap packaging, snaps are universal linux packages Implement snap packaging, snaps are universal linux packages (#119) Mar 6, 2019
@brlin-tw
Copy link
Contributor Author

brlin-tw commented Mar 6, 2019

I just added your e-mail address to the snap's collaborator list, you can now access the current demonstration snap's snapcraft build service page, and the new and legacy snap administration page after login with the Ubuntu One account associate to the e-mail address.

@brlin-tw brlin-tw force-pushed the patch/implement-snap-packaging branch from 6690895 to dc0f429 Compare March 6, 2019 10:18
@brlin-tw
Copy link
Contributor Author

brlin-tw commented Mar 6, 2019

I changed the snap name to gotop-cjbassi for now.

@brlin-tw brlin-tw closed this Mar 12, 2019
@brlin-tw brlin-tw force-pushed the patch/implement-snap-packaging branch from 8bf23ea to 70339c4 Compare March 12, 2019 06:55
This patch implements the necessary details to package gotop as a snap
that can be installed on various GNU/Linux distributions supported by
Snapd.

Signed-off-by: 林博仁(Buo-ren Lin) <[email protected]>
@brlin-tw
Copy link
Contributor Author

brlin-tw commented Mar 12, 2019

I somehow got the pull request messed up so I recreated it from scratch again(sorry about that), please review.

@brlin-tw brlin-tw reopened this Mar 12, 2019
omar-polo and others added 5 commits March 23, 2019 01:50
"RX" is all caps so either "TX" should also be or none. All caps might be the most common form for both.
[pull] patch/implement-snap-packaging from master
@cjbassi
Copy link
Owner

cjbassi commented Apr 25, 2019

Cherry picked the commit onto master in 0817bea, so this is effectively merged. Thanks!

@cjbassi cjbassi closed this Apr 25, 2019
@brlin-tw brlin-tw deleted the patch/implement-snap-packaging branch April 25, 2019 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants