Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: fix README, CancelledError is a BaseException since 3.8 #9

Open
cjrh opened this issue Aug 20, 2022 · 0 comments · May be fixed by ALkonrad/coroexecutor#1
Open

DOC: fix README, CancelledError is a BaseException since 3.8 #9

cjrh opened this issue Aug 20, 2022 · 0 comments · May be fixed by ALkonrad/coroexecutor#1
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@cjrh
Copy link
Owner

cjrh commented Aug 20, 2022

The README currently says this:

Consider the previous example using aiohttp to fetch URLs: inside the fetch() function, we're handling Exception, which includes asyncio.CancelledError

This is incorrect since Python 3.8, when the superclass of asyncio.CancelledError changed from Exception to BaseException. See https://docs.python.org/3/library/asyncio-exceptions.html#asyncio.CancelledError
@cjrh cjrh added good first issue Good for newcomers documentation Improvements or additions to documentation labels Aug 20, 2022
ALkonrad added a commit to ALkonrad/coroexecutor that referenced this issue Aug 20, 2022
@ALkonrad
Update README.rst
8e2e1b6 
Fixed cjrh#9 by changing the README file under Dealing with errors and cancellation from:
the ``fetch()`` function, we're handling ``Exeption``, which
to:
the ``fetch()`` function, we're handling ``BaseExeption``, which
@ALkonrad ALkonrad linked a pull request Aug 20, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README.rst ALkonrad/coroexecutor
1 participant
@cjrh