Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

External modifications of the editing root should not crash the editor #220

Closed
wants to merge 1 commit into from

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Sep 13, 2019

Suggested merge commit message (convention)

External modifications of the editing root should not crash the editor. Closes ckeditor/ckeditor5#2016.


Additional information

  • I've found out that if we initialize the editing area directly as a Vue component root then Vue updates the children of the editing area on removing all nodes.
  • This touches only EditorInline and BallonEditor as those are used directly as a component root. The ClassicEditor is not touched by this as its editing area is wrapped in another <div> which is then used as component root.
  • More links here: Exception on delete value ckeditor5#2016 (comment).
  • This behavior in Vue is didctated by some old Chrome bug (v. 55): textNode removed unexpectedly due to Chrome 55 bug vuejs/vue#6601

@jodator
Copy link
Contributor Author

jodator commented Sep 19, 2019

As it turned out the issue was already fixed by: ckeditor/ckeditor5-vue#52.

@jodator jodator closed this Sep 19, 2019
@jodator jodator deleted the t/ckeditor5/2016 branch September 19, 2019 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception on delete value
2 participants