fix XRPLF#4569: clang warning about deprecated sprintf usage.

Instead of sprintf use the suggested snprintf function
ckeshava · Jun 12, 2023 · 85f1ba7 · 85f1ba7
1 parent c9a586c
commit 85f1ba7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/ripple/basics/impl/contract.cpp b/src/ripple/basics/impl/contract.cpp
@@ -20,7 +20,6 @@
 #include <ripple/basics/Log.h>
 #include <ripple/basics/contract.h>
 #include <cstdlib>
-#include <exception>
 #include <iostream>
 
 namespace ripple {

diff --git a/src/ripple/json/impl/json_reader.cpp b/src/ripple/json/impl/json_reader.cpp
@@ -22,7 +22,6 @@
 
 #include <algorithm>
 #include <cctype>
-#include <cstdint>
 #include <istream>
 #include <string>
 
@@ -925,7 +924,15 @@ Reader::getLocationLineAndColumn(Location location) const
     int line, column;
     getLocationLineAndColumn(location, line, column);
     char buffer[18 + 16 + 16 + 1];
-    sprintf(buffer, "Line %d, Column %d", line, column);
+    int generatedStrLen =
+        snprintf(buffer, 51, "Line %d, Column %d", line, column);
+
+    if (generatedStrLen < 0)
+    {
+        ripple::LogicError(
+            "json_reader: Exception in "
+            "getLocationLineAndColumn - Could not write into buffer\n");
+    }
     return buffer;
 }