Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version-sync #1770

Closed
wants to merge 1 commit into from
Closed

Update version-sync #1770

wants to merge 1 commit into from

Conversation

CreepySkeleton
Copy link
Contributor

@CreepySkeleton CreepySkeleton commented Mar 30, 2020 •
edited
Loading

The issue with blockquotes has now been fixed!

pksunkara
pksunkara approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 30, 2020

👎 Rejected by PR status

@pksunkara
Copy link
Member

The fix actually does not fix our issue since we don't have a version here.

@CreepySkeleton
Copy link
Contributor Author

Oh, right. We do not depend on clap on our own, we show how to do that to our users. It shouldn't be checked.

@pksunkara
Copy link
Member

We should be doing this when we release the next version.

@CreepySkeleton
Copy link
Contributor Author

For the record - git deps are handled just fine:
https://github.com/mgeisler/version-sync/blob/a4aab0f7d721894bb7cb0b2f068c6b3ef35023ca/src/markdown_deps.rs#L20-L39

@CreepySkeleton
Copy link
Contributor Author

Doing what?

@Dylan-DPC-zz
Copy link

@CreepySkeleton

Oh, right. We do not depend on clap on our own, we show how to do that to our users. It shouldn't be checked.

why would clap depend on clap? :P

@CreepySkeleton CreepySkeleton deleted the update branch April 10, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CreepySkeleton @pksunkara @Dylan-DPC-zz