Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix None not being supported as Field values #57

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Conversation

clarkduvall
Copy link
Owner

Fixes #56

This brings serpy more in line with DRF when encountering None values. For more info, see #56

The behavior for serpy is now:

required=True required=False
data = {'value': 1} {'value': 1} {'value': 1}
data = {'value': None} {'value': None} {'value': None}
data = {} KeyError('value',) {}

@coveralls
Copy link

coveralls commented Nov 28, 2017

Coverage Status

Coverage decreased (-3.2%) to 96.774% when pulling f645934 on fix-none into 8954cdf on master.

@clarkduvall clarkduvall merged commit 6ff0f8b into master Nov 28, 2017
@clarkduvall clarkduvall deleted the fix-none branch November 28, 2017 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants