fix: don't lockup in React strict mode when using DragDropManager #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid passing the manager to the state initializer, as this causes issues with React strict mode. Instead, rely on the useEffect callback, already defined. The \`manager\` arg passed back to the initializer function will now always be undefined, making it redundant. It's still possible to cause strict mode to fail when using your own initalizer function to define a manager outside of dnd-kit, and pass it into the DragDropProvider.
chrisvxd
added a commit
to measuredco/puck
that referenced
this pull request
Dec 4, 2024
Still require this upstream update for a full fix: clauderic/dnd-kit#1554
75 tasks
chrisvxd
added a commit
to measuredco/puck
that referenced
this pull request
Dec 4, 2024
Still require this upstream update for a full fix: clauderic/dnd-kit#1554
clauderic
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid passing the manager to the state
initializer, as this causes issues with React strict mode. Instead, rely on theuseEffectcallback, already defined.The
managerarg passed back to the initializer function will now always be undefined, making it redundant.It's still possible to cause strict mode to fail when using your own initalizer function to define a manager outside of dnd-kit, and pass it into the
DragDropProvider.