End keyboard drag operation when pressing tab #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 62f632a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
|
Hi, thank you for this improvement. Note that if you lose focus with the mouse, you still get an inconsistent state where the option is shown as being dragged but it isn't. Also, I can recover focus with arrow keys but then I can't move the items. That is why in #1087 drag is deactivated on a blur event (it doesn't matter what causes it), and this doesn't happen. Screen.Recording.2024-12-12.at.13.24.12.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #857
This PR takes a different approach from #1087 and only de-activates the drag operation when the
Tabkey is pressed. This mostly accomplishes the same thing, but feels like a less risky change as there could be all sorts of factors that cause the draggable item to lose focus.