Unsubscribe all events #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 26, 2021 16:37
__networkChanged__ will emit the network ID as a decimal string __chainChanged__ will emit the chain ID as a hexadecimal string I commented out the __chainChanged__ listener since only one chain / network listener is needed.
I just noticed that __networkChanged__ is deprecated so I removed it.
clbrge
requested changes
Jul 26, 2021
src/web3-store.js
Outdated
| close, | ||
| disconnect, |
There was a problem hiding this comment.
I think we should leave close as an alias not to break code on upgrade so brutally. close can console.log deprecated and call disconnect
There was a problem hiding this comment.
I think we don't need the log then, unless you plan to change the function name to disconnect in the future.
ghost
requested a review
from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networkChanged will emit the network ID as a decimal string
chainChanged will emit the chain ID as a hexadecimal string
I removed the networkChanged listener since only one chain / network listener is needed.