Make ErrorReason public #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue with accessing the ErrorMessage class and its message() method in a legacy Scala codebase. The change involves adjusting the visibility of the ErrorReason interface to make it explicitly public.
The issue surfaced when integrating the Clerk backend API into a legacy Scala codebase that uses older Jackson libraries. While shading the Jackson library was required for compatibility, it's unclear if this specifically caused the accessibility issue with the ErrorReason interface.
By explicitly marking the interface as public, this change ensures compatibility and resolves the accessibility problem.
The modification is minimal, aligns with Java's standard visibility practices, and avoids unnecessary complexity.