-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged #68 : Added click's autocompletion support #88
Merged #68 : Added click's autocompletion support #88
Conversation
Splitted code into functions to test : click_repl/utils.py modified: tox.ini
Added some more tests: tests/test_basic.py Added some more tests: tests/test_command_collection.py Added some tests: tests/test_complete.py Added some dev functions only tests: tests/test_dev/test_get_internal_cmds.py Added some dev functions only tests: tests/test_dev/test_internal_cmds.py Added some dev functions only tests: tests/test_dev/test_register_internal_cmds.py Added some dev functions only tests: tests/test_dev/test_sys_cmds.py Added some more tests: tests/test_repl.py
Formatted by black: click_repl/utils.py Removed mypy config: setup.cfg Formatted by black:: tests/test_command_collection.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we check if we can consider this package for test?
https://pypi.org/project/pytest-click/
You can check it whether it can be used for tests or not But it will still test only the click commands, but not the click_repl package as far as I've seen from the docs |
@@ -2,7 +2,7 @@ click-repl | |||
=== | |||
|
|||
[![build](https://travis-ci.org/click-contrib/click-repl.svg?branch=master)](https://travis-ci.org/click-contrib/click-repl) | |||
[![Tests](https://github.com/GhostOps77/click-repl/actions/workflows/tests.yml/badge.svg?branch=GhostOps77-patch-1)](https://github.com/GhostOps77/click-repl/actions/runs/4074019555/jobs/7018648133) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why referencing your repo instead of main repo?
Replaced the link to my repo to the click_repl's main repo
@auvipy Changed it, check it out And also, I don't know what to do with the build badge, cuz there's no purpose in having it as we've remove the travis ci configs But it's up to u now |
And I think these PR/Issues can be closed as well (also updated at the 1st comment) |
@auvipy hey, are u able to do the test using pytest-click? And also, why don't you close those issues mentioned above? |
Added the click's autocompletion support for click v7 and v8
Also added some test cases for it
And I've also segregated the test cases into separate file
I've moved all the main code to utils.py, and imported only the essential parts from the code explicitly, that the user's gonna use
Solves: #69
And It also merges all my final changes in my main click-repl repository
After merging this PR, you can close these issues/PR
Add support for new click's version autocompletion flag #68
Issue #68, added support in click's autocompletion #69
Don't suggest hidden commands&options #64
Fix: filter hidden commands&options #65
Current test will probably not run because of travis changes #74
setup New CI with GHA #80
update CI #82
Run tests in tox #54
No completion of type=click.Choice for Options #66
And after all that, don't forget to update the version number