Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native stack trace test and remove TIMERWRAP assertion in Node 11 #282

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Fix native stack trace test and remove TIMERWRAP assertion in Node 11 #282

merged 2 commits into from
Dec 4, 2018

Conversation

goto-bus-stop
Copy link
Contributor

In v8 7.0, Array.sort() was moved from a JS-based implementation to
Torque:
v8/v8@fa11e2a

This means Array.sort() isn't in v8's array.js file anymore.
Apparently the goal is to eventually move all or most JS implementations
of builtins like Array to to Torque, so 'native' is a shrinking
category. We may need to do something to detect those Torque things?

@goto-bus-stop
Fix native stack trace test
b589f03 
In v8 7.0, Array.sort() was moved from a JS-based implementation to
Torque:
v8/v8@fa11e2a

This means Array.sort() isn't in v8's `array.js` file anymore.
Apparently the goal is to eventually move all or most JS implementations
of builtins like Array to to Torque, so 'native' is a shrinking
category. We may need to do something to detect those Torque things?
@goto-bus-stop goto-bus-stop changed the title Fix native stack trace test Fix native stack trace test in Node 11 Dec 4, 2018
@AlanSl
Copy link
Contributor

AlanSl commented Dec 4, 2018 •
edited
Loading

Running tests locally on Node 11.3.0 (macOS 10.12.6) I get one test failing:

test/cmd-collect.test.js .............................. 1/2 861ms
  collect command produces data files with content
  not ok should be equivalent strictly
    +++ found                                                           
    --- wanted                                                          
     [                                                                  
    -  "TIMERWRAP"                                                      
       "Timeout"                                                        
     ]

Same with and without coverage.

@goto-bus-stop
Copy link
Contributor Author

Yea I get the same, haven't figured that one out yet!

@AlanSl
Copy link
Contributor

AlanSl commented Dec 4, 2018 •
edited
Loading

Same thing on Windows, everything passes except that (this'll be much easier when the new CI is all working!)

@goto-bus-stop
Copy link
Contributor Author

goto-bus-stop commented Dec 4, 2018 •
edited
Loading

nodejs/node#20894 "refactor timers to remove TimerWrap"

I guess it's expected that that's no longer there in v11

@mcollina
Copy link
Contributor

mcollina commented Dec 4, 2018

I did this all already in #281.
The fix in here is actually better.

mcollina
mcollina approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Contributor

mcollina commented Dec 4, 2018

https://github.com/nearform/node-clinic-bubbleprof/pull/281/files#diff-23e70a192262067a7bfa7bccd55d5ae3

@goto-bus-stop goto-bus-stop changed the title Fix native stack trace test in Node 11 Fix native stack trace test and remove TIMERWRAP assertion in Node 11 Dec 4, 2018
@goto-bus-stop goto-bus-stop merged commit dbb00fb into master Dec 4, 2018
@goto-bus-stop goto-bus-stop deleted the fix/node-11-array.sort-frame branch December 5, 2018 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goto-bus-stop @AlanSl @mcollina