This repository has been archived by the owner on May 31, 2023. It is now read-only.
Cleaner and more general handling of auth options #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was done to prevent including incorrect options, without this anything can be put into configuration which in turn can render grafana inoperational. But I think it would be ok to change it now. You also included binary swap file from vim. TIP: add a global .gitignore file and exlude common files there, more https://help.github.com/en/github/using-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer |
Before this change, the keys of grafana_auth's value were tested for a static list of names like 'disable_login_form'. If they didn't match it would suppose they're a mapping and thus descent into it. This would work as long as the key was in the list, but for example using 'login_maximum_inactive_lifetime_days' would fail as it's not a hash, but it is a valid grafana option. This change makes the test more elegant, robust and easier to maintain. Fixes cloudalchemy#218
faxm0dem
force-pushed
the
fix/additional-auth-options
branch
from
c23a74b to
506bbd2
Compare
|
sorry about the swap file, I just removed it |
|
Sorry to poke you, but (when) do you plan to merge this ? |
|
thanks for merging this ! |
cosandr
pushed a commit
to cosandr/ansible-grafana
that referenced
this pull request
Aug 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the keys of grafana_auth's value were tested for a
static list of names like 'disable_login_form'. If they didn't match it
would suppose they're a mapping and thus descent into it.
This would work as long as the key was in the list, but for example
using 'login_maximum_inactive_lifetime_days' would fail as it's not a
hash, but it is a valid grafana option.
This change makes the test more elegant, robust and easier to maintain.
Fixes #218