Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

add test for custom grafana auth section option #222

Merged
merged 1 commit into from
May 29, 2020

Conversation

faxm0dem
Copy link
Contributor

DISCLAIMER I'm new to molecule

@github-actions github-actions bot added the area/tests Everything related to molecule tests and linters label May 29, 2020
@paulfantom
Copy link
Member

Thank you! 👍

Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@faxm0dem faxm0dem changed the title WIP: add test for custom grafana auth section option add test for custom grafana auth section option May 29, 2020
@faxm0dem
Copy link
Contributor Author

your test matrix is nuts ! my 32GB RAM i7 laptop went bananas for half an hour ;-)
but it's awesome anyway

@faxm0dem faxm0dem force-pushed the test-custom-auth-options branch from 76f789c to 69bbf03 Compare May 29, 2020 15:22
@paulfantom
Copy link
Member

your test matrix is nuts ! my 32GB RAM i7 laptop went bananas for half an hour ;-)

I try to have as much test coverage as possible and since travis does it in parallel, I usually create a PR and let CI do its job :)

@paulfantom paulfantom merged commit 8232050 into cloudalchemy:master May 29, 2020
@faxm0dem faxm0dem deleted the test-custom-auth-options branch June 2, 2020 12:20
cosandr pushed a commit to cosandr/ansible-grafana that referenced this pull request Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tests Everything related to molecule tests and linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants