Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

travis: Automatically use the latest Ansible patch releases #41

Merged

Conversation

odyssey4me
Copy link
Collaborator

When a new patch version of Ansible is released, currently the
travis configuration needs to be updated to consume it for tests.

This patch implements a change in the configuration to ensure that
the latest patch release for each minor series tested is always used.

@odyssey4me odyssey4me force-pushed the simpler-travis-config-maint branch from 13c8f49 to fb8f8a1 Compare March 22, 2018 12:02
.travis.yml Outdated
- ANSIBLE=2.2.3
- ANSIBLE=2.3.3
- ANSIBLE=2.4.3
- ANSIBLE='>2.2.0,<2.3.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change it to >= instead of > ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I did initially think that it might make sense to.

@odyssey4me odyssey4me force-pushed the simpler-travis-config-maint branch from fb8f8a1 to 0968c0b Compare March 22, 2018 12:05
When a new patch version of Ansible is released, currently the
travis configuration needs to be updated to consume it for tests.

This patch implements a change in the configuration to ensure that
the latest patch release for each minor series tested is always used.
@odyssey4me odyssey4me force-pushed the simpler-travis-config-maint branch from 0968c0b to 40ab250 Compare March 22, 2018 12:10
install:
- pip install ansible==${ANSIBLE} ansible-lint>=3.4.15 molecule==1.25.0 docker git-semver 'testinfra>=1.7.0,<=1.10.1'
- pip install ${ANSIBLE} 'ansible-lint>=3.4.15' 'molecule==1.25.0' docker git-semver 'testinfra>=1.7.0,<=1.10.1'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative way to do this is:

ANSIBLE='>=2.2.0,<2.3.0'
pip install ansible${ANSIBLE}

But I think the approach taken in the PR is more readable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, one from PR is better.

@odyssey4me
Copy link
Collaborator Author

Haha, the failure to download the dashboard is fixed in #40 :)

Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm merging both, let's see what will happen 😄

@paulfantom paulfantom merged commit 4d80c37 into cloudalchemy:master Mar 22, 2018
@odyssey4me odyssey4me deleted the simpler-travis-config-maint branch March 22, 2018 12:31
@odyssey4me
Copy link
Collaborator Author

Fantastic, thanks. Do you guys hang out on IRC/Slack somewhere? My next updates are more feature orientated so it might need some discussion.

@paulfantom
Copy link
Member

RIght now we don't have any, but I can set up IRC channel. I'll be back with more info.

@odyssey4me
Copy link
Collaborator Author

I'm already on freenode, if that helps.

@paulfantom
Copy link
Member

That's exactly where I wanted to start a channel 😄

@paulfantom
Copy link
Member

@rdemachkovych
@odyssey4me

I've started a channel #cloudalchemy on freenode.net: http://webchat.freenode.net/?channels=cloudalchemy

paulfantom added a commit to cloudalchemy/ansible-blackbox-exporter that referenced this pull request Mar 22, 2018
paulfantom added a commit to cloudalchemy/ansible-snmp-exporter that referenced this pull request Mar 22, 2018
paulfantom added a commit to cloudalchemy/ansible-alertmanager that referenced this pull request Mar 22, 2018
paulfantom added a commit to cloudalchemy/ansible-node-exporter that referenced this pull request Mar 22, 2018
paulfantom added a commit to cloudalchemy/ansible-prometheus that referenced this pull request Mar 22, 2018
slomo pushed a commit to slomo/ansible-prometheus that referenced this pull request Dec 12, 2018
@lock
Copy link

lock bot commented Mar 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants