-
Notifications
You must be signed in to change notification settings - Fork 308
travis: Automatically use the latest Ansible patch releases #41
travis: Automatically use the latest Ansible patch releases #41
Conversation
13c8f49
to
fb8f8a1
Compare
.travis.yml
Outdated
- ANSIBLE=2.2.3 | ||
- ANSIBLE=2.3.3 | ||
- ANSIBLE=2.4.3 | ||
- ANSIBLE='>2.2.0,<2.3.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change it to >=
instead of >
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I did initially think that it might make sense to.
fb8f8a1
to
0968c0b
Compare
When a new patch version of Ansible is released, currently the travis configuration needs to be updated to consume it for tests. This patch implements a change in the configuration to ensure that the latest patch release for each minor series tested is always used.
0968c0b
to
40ab250
Compare
install: | ||
- pip install ansible==${ANSIBLE} ansible-lint>=3.4.15 molecule==1.25.0 docker git-semver 'testinfra>=1.7.0,<=1.10.1' | ||
- pip install ${ANSIBLE} 'ansible-lint>=3.4.15' 'molecule==1.25.0' docker git-semver 'testinfra>=1.7.0,<=1.10.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative way to do this is:
ANSIBLE='>=2.2.0,<2.3.0'
pip install ansible${ANSIBLE}
But I think the approach taken in the PR is more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, one from PR is better.
Haha, the failure to download the dashboard is fixed in #40 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm merging both, let's see what will happen 😄
Fantastic, thanks. Do you guys hang out on IRC/Slack somewhere? My next updates are more feature orientated so it might need some discussion. |
RIght now we don't have any, but I can set up IRC channel. I'll be back with more info. |
I'm already on freenode, if that helps. |
That's exactly where I wanted to start a channel 😄 |
I've started a channel #cloudalchemy on freenode.net: http://webchat.freenode.net/?channels=cloudalchemy |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When a new patch version of Ansible is released, currently the
travis configuration needs to be updated to consume it for tests.
This patch implements a change in the configuration to ensure that
the latest patch release for each minor series tested is always used.