dashboards: Make the regex much more specific #45
Conversation
|
Please write a comment before task or a better task name explaining what those hieroglyphs do. I fear we might forget and this part will become unmaintainable. |
|
:) will do |
To make sure that we're not being too greedy with the regex
replacement of the data source to use for each dashboard
that's uploaded, we make it much more specific using the
following:
- literal boundaries for " on either side of the match
- non-capturing optional group matches for the ${} bits
- the case-sensitive literal match for DS_ which is
always in every exported dashboard representing the
data source used
- a one-or-more case-sensitive match for the part that
follows the underscore, with no characters allowed
except alphabetical
This should prevent mistaking any capitalised labels or
anything else which may be present in the dashboard.
odyssey4me
force-pushed
the
more-restrictive-regex
branch
from
d2e3fa5 to
251c7a2
Compare
|
dahsboards such as these: use a datasource placeholder which does not fit the pattern expected by the regex (in this case DS_NDF_APP ). Should this be reconsidered? |
|
this would fix it: "(?:${)?DS(_([A-Z])+)+(?:})?" by allowing one or more words delimited by underscores |
|
Ah, I wasn't aware that additional underscores were an option. Could you push up a PR and add that example into the regex tester reference (and update it)? Alternatively, let me know and I'll push up a patch with the changes. |
|
PR: #53 :) |
|
Excellent, thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
To make sure that we're not being too greedy with the regex
replacement of the data source to use for each dashboard
that's uploaded, we make it much more specific using the
following:
always in every exported dashboard representing the
data source used
follows the underscore, with no characters allowed
except alphabetical
This should prevent mistaking any capitalised labels or
anything else which may be present in the dashboard.
This regex can be tested and understood better by looking at the
matches and non-matches in https://regex101.com/r/f4Gkvg/2
versus the current regex and same data set shown in
https://regex101.com/r/Ad9f5U/1