Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Add LDAP configuration tasks #65

Merged
merged 2 commits into from
Jun 16, 2018
Merged

Add LDAP configuration tasks #65

merged 2 commits into from
Jun 16, 2018

Conversation

lae
Copy link
Contributor

@lae lae commented Jun 15, 2018

Fixes #11

This adds a grafana_ldap role variable that is used in populating the LDAP configuration file (which can be configured to be something other than the default).

Group mappings are defined on an organization basis rather than a several separate mappings.

There's one shortcoming in this PR - extra organizations aren't created if they're defined. I was thinking I would hit the API to do so, but I'm not sure how I would go about creating organizations with specific IDs correctly (say I defined org 3 before 2 in group_mappings, or even skipped org.id: 2) when the API (understandably) only lets you create the next available org_id with a name.

@@ -16,6 +16,7 @@ def test_directories(host):
]
files = [
"/etc/grafana/grafana.ini"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lacks , at the end of line

@paulfantom
Copy link
Member

Seems like yamllint doesn't like booleans starting from uppercase letter:

--> Executing Yamllint on files found in /home/travis/build/cloudalchemy/ansible-grafana/...
    /home/travis/build/cloudalchemy/ansible-grafana/molecule/alternative/playbook.yml
      20:24     warning  truthy value should be true or false  (truthy)
      23:24     warning  truthy value should be true or false  (truthy)
      27:18     warning  truthy value should be true or false  (truthy)
      28:20     warning  truthy value should be true or false  (truthy)
      29:26     warning  truthy value should be true or false  (truthy)

@lae
Copy link
Contributor Author

lae commented Jun 15, 2018

Yeah, I usually write bools in lowercase but was attempting to mimic style from the allow_sign_up right above where I edited the defaults in this role - I guess that was a mistake so I went ahead and fixed that and made the README consistent as well.

@paulfantom paulfantom merged commit f5b6427 into cloudalchemy:master Jun 16, 2018
@lock
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants