Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

move to molecule 2.x #108

Merged
merged 10 commits into from
May 14, 2018
Merged

move to molecule 2.x #108

merged 10 commits into from
May 14, 2018

Conversation

paulfantom
Copy link
Member

@paulfantom paulfantom commented May 8, 2018

Resolves #93

  • support molecule 2.x
  • fix linter warnings and errors
  • update guidelines on how tests work
  • add travis pipeline for latest prometheus version (similar to one ran locally)
  • remove .travis/images.sh script as molecule now uses ansible for provisioning
  • add info about IRC channel to CONTRIBUTING.md
  • two test scenarios (default variables and changed ones)

Molecule now uses its own directory, which has following structure:

├── default           # Directory containing test scenario (scenario name is in molecule.yml)
│    ├── create.yml   # Playbook used for environment creation - containers provisioning
│    ├── destroy.yml  # Playbook to cleanup everything after tests
│    ├── molecule.yml # Molecule configuration for this test scenario
│    ├── playbook.yml # Actual tests playbook, role provisioning
│    ├── prepare.yml  # Not used, usually used for environment preconfiguration after creation
│    └── tests
│        └── test_default.py     # testinfra tests
└── alternative
    ├── molecule.yml
    ├── playbook.yml
    └── tests
        └── test_alternative.py

Apart from this it uses .yamllint file for linter configuration.

Multiple test scenarios will significantly extend CI test time. This could be parallelized by running each scenario in different travis pipeline. However this will result in 14 parallel travis pipelines, and travis-ci.org won't allow more than 5 concurent pipelines, so I don't think this will help much.

@paulfantom paulfantom requested review from rdemachkovych and SuperQ May 8, 2018 11:34
@paulfantom paulfantom merged commit 5545dc4 into master May 14, 2018
@paulfantom paulfantom deleted the molecule2 branch May 14, 2018 10:48
slomo pushed a commit to slomo/ansible-prometheus that referenced this pull request Dec 12, 2018
* move to molecule 2.x; add test scenarios; fix linter; modify guidelines

* convert bool to string, so molecule won't fail ¯\_(ツ)_/¯

* fix testinfra tests

* fix tests

* check for absent files
@lock
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to molecule 2.x
2 participants