Remove unnecessary writer close

[jiangphcn]

Overview

Remove unnecessary writer:close() when there is IOException. Otherwise, close() will commit pending updates and close the index. This is not expected.

Testing recommendations

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.cloudant.clouseau.AnalyzerServiceSpec
Running com.cloudant.clouseau.AnalyzerServiceSpec
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.025 sec
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.26 sec
Running com.cloudant.clouseau.ClouseauTypeFactorySpec
Running com.cloudant.clouseau.ClouseauTypeFactorySpec
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.028 sec
Running com.cloudant.clouseau.IndexManagerServiceSpec
Running com.cloudant.clouseau.IndexManagerServiceSpec
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.689 sec
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.712 sec
Running com.cloudant.clouseau.ClouseauQueryParserSpec
Running com.cloudant.clouseau.ClouseauQueryParserSpec
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.025 sec
Running com.cloudant.clouseau.IndexServiceSpec
Running com.cloudant.clouseau.IndexServiceSpec
Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.169 sec
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.188 sec
Running com.cloudant.clouseau.SupportedAnalyzersSpec
Running com.cloudant.clouseau.SupportedAnalyzersSpec
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec
Tests run: 43, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.114 sec
Running com.cloudant.clouseau.IndexCleanupServiceSpec
Running com.cloudant.clouseau.IndexCleanupServiceSpec
2019-11-20 10:16:36 clouseau.cleanup [INFO] Renaming '/Users/jiangph/couchdb/clouseau.dreyfus/clouseau/target/indexes/foo.1234567890' to '/Users/jiangph/couchdb/clouseau.dreyfus/clouseau/target/indexes/foo.20191120.021636.deleted.1234567890'
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.043 sec
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.052 sec

Results :

Tests run: 95, Failures: 0, Errors: 0, Skipped: 0

Related Issues or Pull Requests

apache/couchdb#2130
#23

Checklist

• Code is written and works correctly

• Changes are covered by tests

• Any new configurable parameters are documented in rel/overlay/etc/default.ini

• A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

[theburge]

No, this isn't it either. :D

Without some kind of close, we risk leaving the write lock dangling.