relative .pb.go generation, go_package set to package name #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winecraft-dev
force-pushed
the
fix/proto
branch
from
fcf2df5 to
30f5df6
Compare
|
SGTM but I know next to nothing about proto, so @embano1 and @lionelvillard for review |
winecraft-dev
force-pushed
the
fix/proto
branch
3 times, most recently
from
1f341ac to
468b348
Compare
|
ping @embano1 @lionelvillard |
|
@jnorman-us can you please rebase this? |
Signed-off-by: AYS289 <[email protected]>
Signed-off-by: AYS289 <[email protected]>
winecraft-dev
force-pushed
the
fix/proto
branch
from
3937bc1 to
c8cbca9
Compare
embano1
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #962
In the .proto file,
option go_packageis used for pointing to the generated pb package. I'm importing the cloudevents.proto for creating gRPC handlers functions that accept a CloudEvent, but the import breaks becausego_packagepoints to a local path.I set
go_packagetogithub.com/cloudevents/sdk-go/binding/format/protobuf/v2/pbwhich Go is able to resolve. However generation was broken until I found this protoc flag in a StackOverflow answer:--go-opts=paths=source_relative.I also changed the package name to
io.cloudevents.v1, just like the format here. Package names are supposed to be unique so there aren't collisions when importing multiple protobuf files.