Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv:get errors out reading --preview key if key is not in JSON format #359

Closed
dukedorje opened this issue Feb 1, 2022 · 3 comments · Fixed by #360 or #350
Closed

kv:get errors out reading --preview key if key is not in JSON format #359

dukedorje opened this issue Feb 1, 2022 · 3 comments · Fixed by #360 or #350

Comments

@dukedorje
Copy link

Wrangler 0.0.15

Expected: kv:get returns the key requested
Actual: Errors out complaining that it's not JSON

yarn wrangler kv:key put oracleKey asdflkjsfad --binding pk --preview

yarn wrangler kv:key get oracleKey --binding pk --preview
Failed to fetch /accounts/6fxxxxxxxxxxxxxxx/storage/kv/namespaces/xxxxxxxxxxxxxxxxxx/values/oracleKey - 200: OK
Invalid JSON response:
asdflkjsfad

compatibility_date = "2022-02-01"
kv_namespaces = [ 
  { binding = "pk", id = "xxxxxxxxxxxx", preview_id = "xxxxxxxxxxxxxxxxx" }
]
@threepointone
Copy link
Contributor

Oh hmm I'd fixed this a while ago, but my fix got lost along the way. Will fix and add a test. Sorry about this!

threepointone added a commit that referenced this issue Feb 1, 2022
@threepointone
fix: kv:key get
08f927c 
The api for fetching a kv value, unlike every other cloudflare api, returns just the raw value as a string (as opposed to the `FetchResult`-style json). However, our fetch utility tries to convert every api response to json before parsing it further. This leads to bugs like #359. The fix is to special case 'raw' requests to simply send the text through.
threepointone added a commit that referenced this issue Feb 1, 2022
@threepointone
fix: kv:key get
e91147b 
The api for fetching a kv value, unlike every other cloudflare api, returns just the raw value as a string (as opposed to the `FetchResult`-style json). However, our fetch utility tries to convert every api response to json before parsing it further. This leads to bugs like #359. The fix is to special case 'raw' requests to simply send the text through.

Fixes #359.
@threepointone threepointone mentioned this issue Feb 1, 2022
Merged
threepointone added a commit that referenced this issue Feb 1, 2022
@threepointone
fix: kv:key get
a25ad36 
The api for fetching a kv value, unlike every other cloudflare api, returns just the raw value as a string (as opposed to the `FetchResult`-style json). However, our fetch utility tries to convert every api response to json before parsing it further. This leads to bugs like #359. The fix is to special case 'raw' requests to simply send the text through.

Fixes #359.
threepointone added a commit that referenced this issue Feb 1, 2022
@threepointone
fix: kv:key get
231e1b3 
The api for fetching a kv value, unlike every other cloudflare api, returns just the raw value as a string (as opposed to the `FetchResult`-style json). However, our fetch utility tries to convert every api response to json before parsing it further. This leads to bugs like #359. The fix is to special case 'raw' requests to simply send the text through.

Fixes #359.
threepointone added a commit that referenced this issue Feb 1, 2022
@threepointone
fix: kv:key get
4b7d878 
The api for fetching a kv value, unlike every other cloudflare api, returns just the raw value as a string (as opposed to the `FetchResult`-style json). However, our fetch utility tries to convert every api response to json before parsing it further. This leads to bugs like #359. The fix is to special case 'raw' requests to simply send the text through.

Fixes #359.
@dukedorje
Copy link
Author

🤘

threepointone added a commit that referenced this issue Feb 2, 2022
@threepointone
fix: kv:key get
8a84664 
The api for fetching a kv value, unlike every other cloudflare api, returns just the raw value as a string (as opposed to the `FetchResult`-style json). However, our fetch utility tries to convert every api response to json before parsing it further. This leads to bugs like #359. The fix is to special case 'raw' requests to simply send the text through.

Fixes #359.
threepointone added a commit that referenced this issue Feb 2, 2022
@threepointone
fix: kv:key get
42f631a 
The api for fetching a kv value, unlike every other cloudflare api, returns just the raw value as a string (as opposed to the `FetchResult`-style json). However, our fetch utility tries to convert every api response to json before parsing it further. This leads to bugs like #359. The fix is to special case for `kv:key get`.

Fixes #359.
threepointone added a commit that referenced this issue Feb 2, 2022
@threepointone
fix: kv:key get
567677c 
The api for fetching a kv value, unlike every other cloudflare api, returns just the raw value as a string (as opposed to the `FetchResult`-style json). However, our fetch utility tries to convert every api response to json before parsing it further. This leads to bugs like #359. The fix is to special case for `kv:key get`.

Fixes #359.
threepointone added a commit that referenced this issue Feb 2, 2022
@threepointone
fix: kv:key get
af5c6b8 
The api for fetching a kv value, unlike every other cloudflare api, returns just the raw value as a string (as opposed to the `FetchResult`-style json). However, our fetch utility tries to convert every api response to json before parsing it further. This leads to bugs like #359. The fix is to special case for `kv:key get`.

Fixes #359.
threepointone added a commit that referenced this issue Feb 2, 2022
@threepointone
fix: kv:key get (#360)
f590943 
The api for fetching a kv value, unlike every other cloudflare api, returns just the raw value as a string (as opposed to the `FetchResult`-style json). However, our fetch utility tries to convert every api response to json before parsing it further. This leads to bugs like #359. The fix is to special case for `kv:key get`.

Fixes #359.
@github-actions github-actions bot mentioned this issue Feb 2, 2022
Merged
@threepointone
Copy link
Contributor

This is fixed in #360, we'll do a wrangler@beta release before the end of the week. you can try it now in wrangler@alpha. Thank you for reporting this!

GregBrimble pushed a commit that referenced this issue Feb 8, 2024
@dependabot @GregBrimble
chore(deps-dev): bump prettier from 2.8.1 to 2.8.2 (#359)
607eb45 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
GregBrimble pushed a commit that referenced this issue Feb 9, 2024
@dependabot @GregBrimble
chore(deps-dev): bump prettier from 2.8.1 to 2.8.2 (#359)
828c1b5 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
GregBrimble pushed a commit that referenced this issue Feb 9, 2024
@dependabot @GregBrimble
chore(deps-dev): bump prettier from 2.8.1 to 2.8.2 (#359)
06c344e 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Feb 10, 2024
Open
Open
Open
Open
Open
Open
This was referenced Feb 17, 2024
Open
Open
Open
Open
This was referenced Feb 24, 2024
Open
Open
Open
Open
Open
Open
This was referenced Mar 4, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 12, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 19, 2024
Open
Open
Open
Open
Open
Open
Open
@Laurry-gee Laurry-gee mentioned this issue Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: kv:key get cloudflare/workers-sdk
Version Packages cloudflare/workers-sdk
2 participants
@threepointone @dukedorje