Fix Pages Functions routing for windows path separator #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this pull request
Feb 1, 2022
Previously route paths were manipulated by file-system path utilities. On Windows this resulted in URLs that had backslashes, which are invalid for such URLs. Fixes cloudflare#51 Closes cloudflare#235 Closes cloudflare#330 Closes cloudflare#327
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this pull request
Feb 1, 2022
Previously route paths were manipulated by file-system path utilities. On Windows this resulted in URLs that had backslashes, which are invalid for such URLs. Fixes cloudflare#51 Closes cloudflare#235 Closes cloudflare#330 Closes cloudflare#327
petebacondarwin
added a commit
that referenced
this pull request
Feb 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used the temporary fix proposed as a starting point on issue #51 to address pages function routing on windows . The issue is that windows paths use the backslash separator, which is carried over to routes, making them unusable. Feel free to propose a better solution.