Fix dev-env logging

[penalosa]

What this PR solves / how to test

Fixes N/A

Various fixes for logging in --x-dev-env, primarily to ensure the hotkeys don't wipe useful output:

• Ensure all direct console logging is through logger.console() so that the hotkeys are correctly rendered
• Ensure esbuild doesn't log directly to the console when guessing the format of a worker
• Ensure hotkeys are unregistered when DevEnv is torndown
• Ensure devEnv.teardown() is called when startDev() encounters a thrown error

Author has addressed the following

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because:
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because:
• Changeset (Changeset guidelines)
  • TODO (before merge)
  • Changeset included
  • Changeset not necessary because:
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bufix

[changeset-bot]

🦋 Changeset detected

Latest commit: f2bd048

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11220052476/npm-package-wrangler-6909

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6909/npm-package-wrangler-6909

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11220052476/npm-package-wrangler-6909 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11220052476/npm-package-create-cloudflare-6909 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11220052476/npm-package-cloudflare-kv-asset-handler-6909

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11220052476/npm-package-miniflare-6909

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11220052476/npm-package-cloudflare-pages-shared-6909

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11220052476/npm-package-cloudflare-vitest-pool-workers-6909

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11220052476/npm-package-cloudflare-workers-editor-shared-6909

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11220052476/npm-package-cloudflare-workers-shared-6909

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240925.0
workerd	1.20240925.0	1.20240925.0
workerd --version	1.20240925.0	2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[andyjessop]

If args.disableDevRegistry, then I think teardownRegistry will be undefined here.

[andyjessop]

LGTM 👍