Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test #6923

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Fix test #6923

merged 5 commits into from
Oct 8, 2024

Conversation

andyjessop
Copy link
Contributor

@andyjessop andyjessop commented Oct 8, 2024

What this PR solves / how to test

Fixes #6422.

Before:

/Users/andy/dev/tmp/empty-interface/src/index.ts
  15:14  error  'request' is defined but never used  @typescript-eslint/no-unused-vars
  15:23  error  'env' is defined but never used      @typescript-eslint/no-unused-vars
  15:28  error  'ctx' is defined but never used      @typescript-eslint/no-unused-vars

/Users/andy/dev/tmp/empty-interface/worker-configuration.d.ts
  3:11  error  An empty interface declaration allows any non-nullish value, including literals like `0` and `""`.
- If that's what you want, disable this lint rule with an inline comment or configure the 'allowInterfaces' rule option.
- If you want a type meaning "any object", you probably want `object` instead.
- If you want a type meaning "any value", you probably want `unknown` instead  @typescript-eslint/no-empty-object-type
  3:11  error  An empty interface is equivalent to `{}`

After:

/Users/andy/dev/tmp/empty-interface/src/index.ts
  15:14  error  'request' is defined but never used  @typescript-eslint/no-unused-vars
  15:23  error  'env' is defined but never used      @typescript-eslint/no-unused-vars
  15:28  error  'ctx' is defined but never used      @typescript-eslint/no-unused-vars

✖ 3 problems (3 errors, 0 warnings)

Note that the recommended setup has error rules for both no-empty-object-type and no-empty-interface, so we need both.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: QoL issue for ESLint users

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 8de6d89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andyjessop andyjessop added the e2e Run wrangler e2e tests on a PR label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11232278746/npm-package-wrangler-6923

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6923/npm-package-wrangler-6923

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11232278746/npm-package-wrangler-6923 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11232278746/npm-package-create-cloudflare-6923 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11232278746/npm-package-cloudflare-kv-asset-handler-6923
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11232278746/npm-package-miniflare-6923
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11232278746/npm-package-cloudflare-pages-shared-6923
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11232278746/npm-package-cloudflare-vitest-pool-workers-6923
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11232278746/npm-package-cloudflare-workers-editor-shared-6923
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11232278746/npm-package-cloudflare-workers-shared-6923

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.1
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@andyjessop andyjessop marked this pull request as ready for review October 8, 2024 09:45
@andyjessop andyjessop requested a review from a team as a code owner October 8, 2024 09:45
@andyjessop andyjessop merged commit 1320f20 into main Oct 8, 2024
22 checks passed
@andyjessop andyjessop deleted the aj/add-empty-interface-disable branch October 8, 2024 10:08
@workers-devprod workers-devprod mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Should wrangler types type the empty Env as {}?
2 participants