Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Separate server registry from file-based registry #6926

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

andyjessop
Copy link
Contributor

@andyjessop andyjessop commented Oct 8, 2024

What this PR solves / how to test

Fixes #000.

This PR prepares the dev registry for easier unit testing by splitting out the file-based registry into its own file.

There are no logic changes, only moving functions around to be better organised.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: Covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Not user-facing.

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: a4fca40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 8, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-wrangler-6926

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6926/npm-package-wrangler-6926

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-wrangler-6926 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-create-cloudflare-6926 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-cloudflare-kv-asset-handler-6926
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-miniflare-6926
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-cloudflare-pages-shared-6926
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-cloudflare-vitest-pool-workers-6926
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-cloudflare-workers-editor-shared-6926
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-cloudflare-workers-shared-6926

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.1
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@andyjessop andyjessop added the e2e Run wrangler e2e tests on a PR label Oct 8, 2024
@andyjessop andyjessop force-pushed the aj/dev-registry-refactor branch from 0f4f6f3 to 91dc6a1 Compare October 9, 2024 10:13
@andyjessop andyjessop force-pushed the aj/dev-registry-refactor branch from 91dc6a1 to 451a168 Compare October 9, 2024 10:20
@andyjessop andyjessop marked this pull request as ready for review October 9, 2024 10:53
@andyjessop andyjessop requested a review from a team as a code owner October 9, 2024 10:53
Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much easier to understand 🎉
For my own curiosity, are we planning to switch to a file-based registry by default soon?

@andyjessop
Copy link
Contributor Author

@emily-shen yes I believe so! Here's hoping that it will provide more stability.

@andyjessop andyjessop merged commit 301d413 into main Oct 10, 2024
23 checks passed
@andyjessop andyjessop deleted the aj/dev-registry-refactor branch October 10, 2024 14:02
@workers-devprod workers-devprod mentioned this pull request Oct 9, 2024
@andyjessop andyjessop restored the aj/dev-registry-refactor branch October 10, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants