-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Separate server registry from file-based registry #6926
Conversation
🦋 Changeset detectedLatest commit: a4fca40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-wrangler-6926 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6926/npm-package-wrangler-6926 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-wrangler-6926 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-create-cloudflare-6926 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-cloudflare-kv-asset-handler-6926 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-miniflare-6926 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-cloudflare-pages-shared-6926 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-cloudflare-vitest-pool-workers-6926 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-cloudflare-workers-editor-shared-6926 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11253754444/npm-package-cloudflare-workers-shared-6926 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
0f4f6f3
to
91dc6a1
Compare
91dc6a1
to
451a168
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much easier to understand 🎉
For my own curiosity, are we planning to switch to a file-based registry by default soon?
@emily-shen yes I believe so! Here's hoping that it will provide more stability. |
What this PR solves / how to test
Fixes #000.
This PR prepares the dev registry for easier unit testing by splitting out the file-based registry into its own file.
There are no logic changes, only moving functions around to be better organised.
Author has addressed the following