-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assets inheritance #7981
Fix assets inheritance #7981
Conversation
🦋 Changeset detectedLatest commit: 8ff64b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-wrangler-7981 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7981/npm-package-wrangler-7981 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-wrangler-7981 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-workers-bindings-extension-7981 -O ./cloudflare-workers-bindings-extension.0.0.0-v8bca2a498.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8bca2a498.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-create-cloudflare-7981 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-kv-asset-handler-7981 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-miniflare-7981 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-pages-shared-7981 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-unenv-preset-7981 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-vite-plugin-7981 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-vitest-pool-workers-7981 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-workers-editor-shared-7981 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-workers-shared-7981 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-workflows-shared-7981 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
0a8d6fe
to
35ad11a
Compare
35ad11a
to
a05be22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending on that test comment, this LGTM. Thank you so much for fixing Walshy
a05be22
to
8ff64b9
Compare
Fixes N/A
Fixes a regression introduced in Wrangler 3.107.0 in which
[assets]
was not being inherited from the top-level environment.