Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assets inheritance #7981

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Fix assets inheritance #7981

merged 1 commit into from
Jan 31, 2025

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented Jan 31, 2025

Fixes N/A

Fixes a regression introduced in Wrangler 3.107.0 in which [assets] was not being inherited from the top-level environment.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no change

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 8ff64b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 31, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-wrangler-7981

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7981/npm-package-wrangler-7981

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-wrangler-7981 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-workers-bindings-extension-7981 -O ./cloudflare-workers-bindings-extension.0.0.0-v8bca2a498.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8bca2a498.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-create-cloudflare-7981 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-kv-asset-handler-7981

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-miniflare-7981

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-pages-shared-7981

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-unenv-preset-7981

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-vite-plugin-7981

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-vitest-pool-workers-7981

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-workers-editor-shared-7981

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-workers-shared-7981

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13073456998/npm-package-cloudflare-workflows-shared-7981

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.1
workerd 1.20250129.0 1.20250129.0
workerd --version 1.20250129.0 2025-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev force-pushed the walshy/fix-assets-inheritance branch from 0a8d6fe to 35ad11a Compare January 31, 2025 12:57
@WalshyDev WalshyDev marked this pull request as ready for review January 31, 2025 12:59
@WalshyDev WalshyDev requested a review from a team as a code owner January 31, 2025 12:59
@WalshyDev WalshyDev force-pushed the walshy/fix-assets-inheritance branch from 35ad11a to a05be22 Compare January 31, 2025 13:05
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending on that test comment, this LGTM. Thank you so much for fixing Walshy ♥️

@WalshyDev WalshyDev force-pushed the walshy/fix-assets-inheritance branch from a05be22 to 8ff64b9 Compare January 31, 2025 13:11
@penalosa penalosa merged commit e2b3306 into main Jan 31, 2025
27 checks passed
@penalosa penalosa deleted the walshy/fix-assets-inheritance branch January 31, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants