Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide unsafe metadata for wrangler versions secret put #8037

Merged

Conversation

WillTaylorDev
Copy link
Contributor

@WillTaylorDev WillTaylorDev commented Feb 5, 2025

In cases of wrangler versions secret put, we were losing the stable name on asset-worker and router-worker. This passes along the unsafe metadata during these deploys.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a

@WillTaylorDev WillTaylorDev requested a review from a team as a code owner February 5, 2025 19:31
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 99039f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 5, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-wrangler-8037

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8037/npm-package-wrangler-8037

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-wrangler-8037 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-cloudflare-workers-bindings-extension-8037 -O ./cloudflare-workers-bindings-extension.0.0.0-va1bf08b7d.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va1bf08b7d.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-create-cloudflare-8037 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-cloudflare-kv-asset-handler-8037

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-miniflare-8037

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-cloudflare-pages-shared-8037

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-cloudflare-unenv-preset-8037

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-cloudflare-vite-plugin-8037

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-cloudflare-vitest-pool-workers-8037

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-cloudflare-workers-editor-shared-8037

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-cloudflare-workers-shared-8037

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13165122680/npm-package-cloudflare-workflows-shared-8037

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250129.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen merged commit 71fd250 into main Feb 7, 2025
27 of 29 checks passed
@emily-shen emily-shen deleted the willtaylor/provide-unsafe-metadata-version-secret-put branch February 7, 2025 13:42
@workers-devprod workers-devprod mentioned this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants